Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): removed __pyodide constant from pythontest evaluator #54827

Conversation

AndrewYturaldi
Copy link
Contributor

Checklist:

Closes #54810

Removed pyodide as specified in the issue.

@AndrewYturaldi AndrewYturaldi requested a review from a team as a code owner May 16, 2024 02:27
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 16, 2024
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: ignore this, working on it

@ilenia-magoni ilenia-magoni added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label May 16, 2024
@ilenia-magoni
Copy link
Contributor

How to unblock: #54832 needs to be merged, then a translation cycle needs to complete, then this branch needs to be updated to match main

@AndrewYturaldi
Copy link
Contributor Author

@ilenia-magoni is there a way I can update the files in the portuguese and italian sections of the curriculum? it appears that is the reason the test are failing. If so, will this require a new issue and pull request?

@ilenia-magoni
Copy link
Contributor

It requires the automatic translation process to happen, please do nothing and wait

@ilenia-magoni ilenia-magoni removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label May 17, 2024
Copy link
Contributor

@ilenia-magoni ilenia-magoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass this should be good to go.

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AndrewYturaldi! LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 5dcda26 into freeCodeCamp:main May 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new python course scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove __pyodide now that all the tests use runPython.
4 participants