fix(curriculum): prevent hardcoding pokemon #54822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
Dario-DC
added
the
new javascript course
...thms-and-data-structures-22/build-a-pokemon-search-app-project/build-a-pokemon-search-app.md
Outdated
Show resolved
Hide resolved
Except there is a solution attached at the bottom of the file you can test against. |
Co-authored-by: Ilenia <26656284+ilenia-magoni@users.noreply.github.com>
moT01
added
the
status: waiting review
JoyShaheb
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Ref #54063
Two tests were added. One randomly generates an invalid Pokemon name and tests for a Pokemon not found response. The other test randomly generates a valid Pokemon id and compares it to the types received from our Pokemon API and sees if they match. If I had just used a few regular names, we would have to continually add new options to our generic tests. It also makes test writing a lot smoother.