New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert dice game into review style project #54821

Open

naomi-lgbt wants to merge 12 commits into freeCodeCamp:main from naomi-lgbt:feat/dice

Member

naomi-lgbt commented May 15, 2024

Checklist:

I have read and followed the contribution guidelines.
I have read and followed the how to open a pull request guide.
My pull request targets the main branch of freeCodeCamp.
I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

naomi-lgbt added 4 commits

May 15, 2024 13:19


          feat: combine DOM variable steps

42fb7e8

Also, rename the variables. Sorry, but currentRoundText.innerText
just doesn't make sense.


          feat: more variable declarations and renames

7517cbb


          feat: condense rules toggle logic

b41449b


          feat: condense roll dice function

github-actions bot added the scope: curriculum label


          chore: meta

7dd610a

github-actions bot added the scope: i18n label

naomi-lgbt added 7 commits

May 22, 2024 09:17


          chore: mergy merge

a3f3e43


          feat: more progress

72f42d8


          feat: finish gutting the steps

2984fac


          chore: mergy merge

99588d1


          feat: some test progress

fa5acf6


          feat: finalise tests

2df3d1d


          feat: rename it

ba9e1b9

github-actions bot added the platform: learn label

naomi-lgbt marked this pull request as ready for review

May 24, 2024 02:02

naomi-lgbt requested review from a team as code owners

May 24, 2024 02:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment