Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reason to followAnnouncements method #10275

Merged

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Resolves #10274

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • Code changes have been tested against the Discord API, or there are no code changes

@sdanialraza sdanialraza requested a review from a team as a code owner May 14, 2024 14:56
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 9:54am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 9:54am

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.14%. Comparing base (bb884fc) to head (9250a83).

Files Patch % Lines
packages/core/src/api/channel.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10275      +/-   ##
==========================================
- Coverage   49.14%   49.14%   -0.01%     
==========================================
  Files         248      248              
  Lines       21212    21213       +1     
  Branches     1037     1037              
==========================================
  Hits        10425    10425              
- Misses      10739    10740       +1     
  Partials       48       48              
Flag Coverage Δ
brokers 0.00% <0.00%> (-49.15%) ⬇️
builders 0.00% <0.00%> (-49.15%) ⬇️
collection 0.00% <0.00%> (-49.15%) ⬇️
discord.js 0.00% <0.00%> (-49.15%) ⬇️
formatters 0.00% <0.00%> (-49.15%) ⬇️
guide 0.00% <0.00%> (-49.15%) ⬇️
next 0.00% <0.00%> (-49.15%) ⬇️
proxy 0.00% <0.00%> (-49.15%) ⬇️
rest 0.00% <0.00%> (-49.15%) ⬇️
voice 0.00% <0.00%> (-49.15%) ⬇️
website 0.00% <0.00%> (-49.15%) ⬇️
ws 0.00% <0.00%> (-49.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit b36ec98 into discordjs:main May 19, 2024
23 checks passed
@sdanialraza sdanialraza deleted the feat/add-reason-follow-announcements branch May 19, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add reason to follow announcement channel endpoint
4 participants