Update the docs for speaking updates #5576
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
vassjozsef
reviewed
May 17, 2024
| @@ -234,6 +234,9 @@ The following flags can be used as a bitwise mask. For example `5` would be prio | |||
| > warn | |||
| > You must send at least one [Opcode 5 Speaking](#DOCS_TOPICS_OPCODES_AND_STATUS_CODES/voice) payload before sending voice data, or you will be disconnected with an invalid SSRC error. | |||
|
|
|||
| > info | |||
| > The `delay` property is ignored for voice connections via the voice gateway. | |||
|
|
|||
There was a problem hiding this comment.
Not true and it is very important. For browser, it must be set to VAD leading value. For Discord Client, it must be set to zero.
There was a problem hiding this comment.
This is only usable by bots though, and bots can't be used in a browser context due to CORS. I'm not sure what I should write then?
I've changed it to just say that bots should set it to 0.
vassjozsef
reviewed
May 17, 2024
|
|
||
| The following flags can be used as a bitwise mask. For example `5` would be priority and voice. | ||
| The following flags can be used as a bitwise mask. For example `5` would be priority and voice. The speaking mode should not be 0 to allow sending audio. |
There was a problem hiding this comment.
Do not understand why this sentence is needed.
There was a problem hiding this comment.
Because you should never set it to 0, it only causes issues.
vassjozsef
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docs are quite outdated, and you no longer need to send a speaking stop indication. The discord client now handles this automatically by removing the speaking indicator when the UDP packets stop arriving.