-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the motorSpeed of the Wheel Joint always being set to a value of 1 #701
base: master
Are you sure you want to change the base?
Conversation
… delta time" This reverts commit 92cd041.
I had some confusion about runtime.GetFPS. |
I think if ( lua_isnumber( L, 3 ) )
{
Rtt_Real valueRadians = Rtt_RealDegreesToRadians( luaL_toreal( L, 3 ) );
joint->SetMotorSpeed( Rtt_RealToFloat( valueRadians ) );
} |
Nice job on the fix! I had a PR (#641) suggesting a solution for the axis issue. Glad to see progress on this. |
OK, I'll do some tests on it. |
Your solution about the axis is correct when normalizing values to 1 or -1. I'm also encountering an issue with the axis of the wheel joint; it seems more like a piston force along the axis. However, this might necessitate changes to the previous project's attributes: springDampingRatio and springFrequency. We need some opinions from @Shchvova , and it should be in a new pull request. |
Issue:
https://github.com/coronalabs/corona/assets/70838508/8b2cc0b4-dc26-49f5-b014-4bd296f5c313
Fixed:
https://github.com/coronalabs/corona/assets/70838508/e76b467e-bd65-404b-a840-6dcfa0e116b1
Code - Test: