Android: fix audio metatable being covered #698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metatable for Android
audio2
overwrites the metatable foraudio
, causing the following properties (obtained by __index) to get incorrectly:And an error prints:
when obtaining the
supportsSessionProperty
instead of returnfalse
:AFAIK, there should be no side effects other than affecting the acquisition of the above properties.
However, it is still necessary to be cautious about merging, because it is possible to break previous usage, although the previous value is always wrong.
Tested with Media/AudioPlayer and the following new lines:
Related to: