Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35386][cdc][docs] Build release-3.1 documentation and mark it as stable #3317

Merged
merged 1 commit into from
May 17, 2024
Merged

[FLINK-35386][cdc][docs] Build release-3.1 documentation and mark it as stable #3317

merged 1 commit into from
May 17, 2024

Conversation

GOODBOY008
Copy link
Member

@GOODBOY008 GOODBOY008 commented May 13, 2024 •
edited

Changes:

  • Enable build check for pr
  • Add release 3.1 doc

@github-actions github-actions bot added the build label May 13, 2024
@GOODBOY008 GOODBOY008 marked this pull request as draft May 13, 2024 04:00
@github-actions github-actions bot added the docs Improvements or additions to documentation label May 13, 2024
@github-actions github-actions bot added docs Improvements or additions to documentation and removed docs Improvements or additions to documentation labels May 13, 2024
@GOODBOY008
Copy link
Member Author

Test ci in https://github.com/apache/flink-cdc/actions/runs/9058511423/job/24884273027?pr=3317

@GOODBOY008 GOODBOY008 marked this pull request as ready for review May 13, 2024 06:56
@github-actions github-actions bot removed the docs Improvements or additions to documentation label May 13, 2024
@GOODBOY008
Copy link
Member Author

@leonardBang @PatrickRen PTAL

@GOODBOY008
Copy link
Member Author

Is this pr will be merged after release vote passed?

@GOODBOY008 GOODBOY008 changed the title [hot][doc-ci] Add release 3.1 and enable build check for pr [FLINK-35386][cdc][docs] Build release-3.1 documentation and mark it as stable May 17, 2024
@PatrickRen
Copy link
Contributor

Is this pr will be merged after release vote passed?

Yes. The documentation can be adjusted anytime

PatrickRen
PatrickRen approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 Thanks for the patch! LGTM

@PatrickRen PatrickRen merged commit 4c0cafe into apache:release-3.1 May 17, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickRen PatrickRen PatrickRen approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GOODBOY008 @PatrickRen