Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First issue lint fix #253

Open
wants to merge 3 commits into
base: v2-development
Choose a base branch
from

Conversation

joemclo
Copy link
Contributor

@joemclo joemclo commented Oct 17, 2020

Hi,

I stumbled upon this repo whilst experiencing the #251 bug and saw that it is open for contributions.

So as a first issue this PR fixes two small lint issues that are reported as warnings when running yarn start command. If this is helpful I might continue contributing and fix some listed issues.

lint issues fixed in this PR

/src/App.js
  Line 153:5:  'PathWithSideMenu' is assigned a value but never used  no-unused-vars

./src/components/LocationBanner/LocationBanner.js
  Line 77:25:  Missing '()' invoking a constructor 

@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2020

This pull request introduces 1 alert when merging 75e4ec8 into 9a3ca57 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@xenatisch
Copy link
Contributor

I really don't like the implementation of menu links. It's in the backlog to reimplement them as a more generic component, instead of adding in individual paths one at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants