Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onStartWithOptions and onMoveWithOptions #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add onStartWithOptions and onMoveWithOptions #3

wants to merge 1 commit into from

Conversation

FabienHenon
Copy link
Contributor

@FabienHenon FabienHenon commented Dec 1, 2017 •
edited

I added 2 new functions: onStartWithOptions and onMoveWithOptions to be able to add options for these events.

This was useful for me when I needed to reproduce a scroll-like feature for my component, without triggering the "real" scroll from my parent element.

PS: I'm wondering if onEnd shouldn't be setting preventDefault to False and let the user set it to True only when needed with onEndWithOptions.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FabienHenon