Use cents instead of percentage to set discount for customer. #29934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanagr
changed the title
This allows us to set the price of a plan exactly as discussed with the customer.
|
Closing in favour of #29957 since we don't need the stripe fixtures as I used the same discount percentages in the tests which resulted in effectively no changes to generated fixtures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use #29957 for code reviews which is without stripe fixture data
First we need to run #29890 for exisitng customers (not required for testing this PR though)
cloud discount
basic free trial discount
business discount
next plan discount