Fix page reflow on Firefox and Safari #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out what this PR was referring to (skill issue I think) so I merged it into my fork hoping it was what I thought it was and yes, it indeed seems to be what I though. For anyone who as me is not getting the gist from ZihaoZhou's description, this fixes the behavior where, upon editing a large chunk of text in the textarea, the line where the cursor is positioned gets displaced to the very bottom of the screen and when pressing ctrl-z, the cursor goes out of sight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Page reflow / shaking on textarea resizing
Step to reproduce: Open BetterChatGPT with Firefox / Safari, go the end of page, type new line in the textarea.
Fix: Use a hidden buffer textarea, calculate the height using it instead of setting textarea to auto everytime