ls source to list current directory, most recent first #98
Conversation
There was a problem hiding this comment.
Thanks PR.
The interface for xclip is good idea, and it will be useful for X11 users. It will be better to supports pbcopy and xsel as possible.
I have two concerns:
- There is
open-filesource to show the result ofls. - xclip feature should not be the main action for this source.
I hope you add "copy to clipboard" action for open-files source instead of creating new source, and configure it as default using custom action introduced in #96
|
|
||
| function zaw-src-ls() { | ||
| # avoid any alias present by calling full path | ||
| savealias=`alias ls` |
There was a problem hiding this comment.
Please use local to restrict scope. You should use command ls if you concern about alias.
| "append filename" "prepend filename") | ||
| } | ||
|
|
||
| function strip-ls-long() { |
There was a problem hiding this comment.
Please rename to zaw-src-ls-strip or some name you prefer to restrict name scope.
| function zaw-src-ls-append() { | ||
| line="$1" | ||
|
|
||
| BUFFER="$BUFFER `print -- $line | strip-ls-long`" |
There was a problem hiding this comment.
Please use $LBUFFER and $RBUFFER
|
OK, thanks for your review, all very reasonable. |
Hi there. In case you like it, I find it useful, but adds deps to xclip and awk
ciao