Set “Defines Module” build setting to Yes for “Finch” #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set the `DEFINES_MODULE` build setting for the “Finch” (static lib) target to `YES` for better interop with Swift— all of Finch's classes will be accessible under the `Finch.…` “namespace”, or via files with `import Finch`.
* Added to “Finch” target `MODULE_NAME` build setting with fixed value `Finch` _(rather than using `$TARGET_NAME` as I've seen done elsewhere— it's less likely that Finch will change its name than it is likely that an additional target could be added)_. * Added to “Finch” target `MODULE_VERSION` build setting with value `1.0.0`.
* Updated `Rakefile`'s `replace_version_number()` method to also open the `.pbxproj` file (`Finch.xcodeproj/project.pbxproj`) and replace instances of `MODULE_VERSION = «current-version»;` with `MODULE_VERSION = «new-version»;`. * New `pbxproj_path()` method works like `podspec_path()` but for the `project.pbxproj` within the 1st-found `*.xcodeproj`. * Also, changed `gsub` pattern for podspec replacement to use a regex non-capturing group _(`(?: )` instead of `( )`)_ so that back references are more logical _(i.e. `\\1` & `\\2` instead of `\\1` & `\\3`)_ and parallel the `gsub` for pbxproj replacement.
|
I noticed that things aren't building/importing as expected, so I'm not quite done with this PR. Please hold off on merging for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFINES_MODULEbuild setting for the “Finch” (static lib) target toYESfor better interop with Swift— all of Finch's classes will be accessible under theFinch.…“namespace”, or via files withimport Finch.