Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod_menu] Make remove from menu text nicer #3688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DorienD
Copy link
Member

@DorienD DorienD commented Feb 22, 2024

Description

The text was the same as when you delete a resource, with a very scary text THIS CANNOT BE UNDONE. So i made it a little friendlier, since it can be undone because the resource is not deleted.

@DorienD DorienD self-assigned this Feb 22, 2024
@mworrell
Copy link
Member

mworrell commented Feb 26, 2024

Maybe we should make it scary only if the referred thing has:

  • is_dependent set; and
  • has only a single incoming edge (ie. the menu resource we are editing).

@mworrell
Copy link
Member

Hmmm, that is then something that needs to be checked before we can show that confirm dialog. We will need an API call for that.

@mworrell
Copy link
Member

Or should we add a property for the rsc model: is_dependent_with_single_referrer ? Kind of ugly.... though it describes the condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants