Add input types to livevalidation #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkatsuba
reviewed
Mar 18, 2023
Comment on lines
+285
to
+300
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'COLOR') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'DATE') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'DATETIME-LOCAL') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'MONTH') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'WEEK') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'TIME') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'RANGE') | ||
| return LiveValidation.TEXT; | ||
| if (nodeName == 'INPUT' && this.element.type.toUpperCase() == 'SEARCH') | ||
| return LiveValidation.TEXT; |
There was a problem hiding this comment.
I suppose that this can be simplify like:
1 - Define a constant eg.:
const x = ['COLOR', 'DATE', 'DATETIME-LOCAL', ''WEEK', ...']2 - Use includes() method for detect if item are exist: eg:
if (nodeName == 'INPUT' && x.includes(this.element.type))There was a problem hiding this comment.
I agree with you, @vkatsuba. This code can be improved, but IMHO, this lib needs to be updated, reviewed, or changed by another one, like Zod. The majority of the code is still the same as the original one (the last commit date is Feb 13, 2010). I just kept the code semantic.
See this comment from @mworrell.
|
Thanks @williamthome, and indeed, the validation code must be revised to include "modern" input types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Livevalidation it's an old lib and not all
inputtypes existed back then.This PR adds the following types:
Checklist