mod_base: Handle unknown categories separately in is_a filter. #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworrell
reviewed
Jul 27, 2022
| @@ -25,9 +25,7 @@ is_a({rsc_list, List}, Cat, Context) -> | |||
| is_a(Arg, Cat, Context) -> | |||
| case m_category:name_to_id(Cat, Context) of | |||
| {ok, CatId} -> z_list_of_ids_filter:filter(Arg, fun(Id) -> m_rsc:is_a(Id, CatId, Context) end, Context); | |||
| {error, {unknown_category, _}} -> false; | |||
| {error, _Reason} when is_integer(Arg) -> false; | |||
There was a problem hiding this comment.
I think this when is too strict.
The check on is_list might move up and this one might just be the default.
Applying the is_a filter on a list (or list-alike thing) should perform like a filter on some category. That is why the when on is_list(Arg) is there, to return an empty list.
There was a problem hiding this comment.
Ah... the error clauses match on the input, not on the error itself.
There was a problem hiding this comment.
Going to do this later today. I'll refactor it a bit to clarify a bit more that is_a produces different answers when there is no match depending on the input.
There was a problem hiding this comment.
The {rsc_list, _} is now also a record: #rsc_list{ list = List }.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3071
Handle the case unknown category separately. This can happen when categories are removed.
Checklist