Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add audit log module #2042

Open
wants to merge 2 commits into
base: 0.x
Choose a base branch
from
Open

WIP: Add audit log module #2042

wants to merge 2 commits into from

Conversation

ddeboer
Copy link
Member

@ddeboer ddeboer commented Apr 11, 2019

Description

Fix #1529.

Checklist

  • Add schema for log_audit table.
  • Update admin templates to show and filter on all #log_audit{} properties, similar to the e-mail log.
  • documentation updated
  • no BC breaks

@ddeboer ddeboer changed the title Add audit log module WIP: Add audit log module Apr 11, 2019
@ddeboer ddeboer mentioned this pull request Apr 11, 2019
value = Value
},
Context
).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these observers are quite verbose, but I like that it’s very explicit.

observe_edge_insert/2,
observe_edge_delete/2,
observe_media_update_done/2,
observe_rsc_update_done/2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other notifications you’d like to see in the audit log?

@mworrell
Copy link
Member

Maybe we could hook into (the results of) mod_ratelimit and mod_clamav ?

@ddeboer
Copy link
Member Author

ddeboer commented Apr 11, 2019

@mworrell Not yet, because they publish no notifications. 😉

@mworrell
Copy link
Member

It might be an idea to be able to hook into the z_notifier to observe the results of first or map notifications? Wondering what the most efficient method could be.

@mmzeeman
Copy link
Member

In the module we made it is possible to have an hierarchy of events so you can easily filter on authentication events, resource modification, etc. In our own codebase we have custom events.

What I don't have right now is an admin interface.

@mworrell
Copy link
Member

mworrell commented May 3, 2019

See also #2057 for some simple logging of system-events using the current logging module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants