[WIP] core: Add generic task queue #1728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Client modules can add items to the queue. * This queue can replace z_pivot_rsc for both its task queue and its pivot queue.
|
@ddeboer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mworrell, @arjan and @ArthurClemens to be potential reviewers. |
ddeboer
added a commit
to driebit/mod_elasticsearch
that referenced
this pull request
Jun 19, 2017
This depends on zotonic/zotonic#1728.
ddeboer
commented
Jun 27, 2017
| ok = z_db:create_table( | ||
| ?TABLE, | ||
| [ | ||
| #column_def{name = id, type = "serial", is_nullable = false, primary_key = true}, |
mworrell
reviewed
Aug 14, 2019
| ok = z_db:create_table( | ||
| ?TABLE, | ||
| [ | ||
| #column_def{name = id, type = "serial", is_nullable = false, primary_key = true}, |
There was a problem hiding this comment.
Use 'bigserial' Every new task will increment, and a system will gather easily millions of tasks a month.
|
|
||
| due(Seconds) when is_integer(Seconds) -> | ||
| calendar:gregorian_seconds_to_datetime( | ||
| calendar:datetime_to_gregorian_seconds(calendar:universal_time() + Seconds) |
There was a problem hiding this comment.
I guess this should be (parentheses):
calendar:datetime_to_gregorian_seconds(calendar:universal_time()) + Seconds| undefined -> | ||
| undefined; | ||
| Task -> | ||
| batch(task(Task), Context) |
There was a problem hiding this comment.
I think we could do this with a single query, where we join the task-queue with itself?
|
|
||
| task(Props) -> | ||
| Callback = list_to_tuple( | ||
| [list_to_atom(binary_to_list(L)) || L <- binary:split(proplists:get_value(callback, Props), <<":">>)] |
There was a problem hiding this comment.
Nowadays we also have binary_to_atom(B, utf8)
|
Saw that a long time ago I started a review, but apparently never clicked on "submit" ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
To do
z_queue:dequeuego through a worker pool (sidejob) to speed up processing but do so safely through capacity limiting. Create a pool per module/function queue callback to separate different types of load/backpressure, e.g. (1) CPU-intensive (resource pivoting, database calls), (2) memory-intensive or (3) dependent on external systems (such as an API or document store).