Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to have a MFA transport #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mmzeeman
Copy link
Member

Added the possibility to add MFA's as transport mechanism.

The reason for this is that when you add a fun as transport, it can become a badrun when the module it originates in undergoes code upgrades. This can result in session crashes. This is prevented by using an MFA.

@mworrell
Copy link
Member

So also no Pid anymore?

@mmzeeman
Copy link
Member Author

So also no Pid anymore?

Oh, I didn't want to remove that. I'll double check.

@mmzeeman
Copy link
Member Author

Ah, no. I re-used the callback type which includes a pid. It is defined like this:

-type callback() :: pid() | {module(), atom(), list()}.
-type transport() :: function() | callback().

@mworrell
Copy link
Member

Ah, then I overlooked that on my phone :-) Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants