Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to combine the old format and the new username format #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heiheshang
Copy link

my devices connect to branch 0.34 with username user@example.com , now i try to update zotonic but my devices are in different country and i can't update them all at once. i tried to check username format and get hostname

@mworrell
Copy link
Member

If I understand correctly then you decide upon the presence of the <<":">> or <<"@">> how to split the username/vhost.

I think this might go wrong on an input like myserver:user@example.com where both a : and @ is in the name, which will give a list of two characters and then crash the match routine.

I think the match routine needs to match on match([?COLON|_], Username)

@heiheshang
Copy link
Author

would this be the correct format myserver:user@example.com ? Previously, everything after @ was the name of the server. match in this case will also work incorrectly. I use binary comprehension to get rid of the double application of match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants