fix: Fix compiler warnings #2255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
suggested changes
Apr 9, 2024
| @@ -93,7 +93,6 @@ void ksbb_inner_kscan_callback(const struct device *dev, uint32_t row, uint32_t | |||
| } | |||
|
|
|||
| static int ksbb_configure(const struct device *dev, kscan_callback_t callback) { | |||
| const struct ksbb_config *cfg = dev->config; | |||
There was a problem hiding this comment.
I'm not sure why this is being removed. It would seem to cause any builds that configure hardware soft-off to fail (e.g. west build -p -b nrf52840dk_nrf52840 -- -DSHIELD=zmk_uno)
There was a problem hiding this comment.
This function seems like it could be condensed:
diff --git a/app/src/display/widgets/layer_status.c b/app/src/display/widgets/layer_status.c
index 70e54ee4..4f462d70 100644
--- a/app/src/display/widgets/layer_status.c
+++ b/app/src/display/widgets/layer_status.c
@@ -23,19 +23,15 @@ struct layer_status_state {
};
static void set_layer_symbol(lv_obj_t *label, struct layer_status_state state) {
- if (state.label == NULL) {
- char text[16] = {};
+ char text[16] = {};
+ if (state.label == NULL) {
snprintf(text, sizeof(text), LV_SYMBOL_KEYBOARD " %i", state.index);
-
- lv_label_set_text(label, text);
} else {
- char text[16] = {};
-
snprintf(text, sizeof(text), LV_SYMBOL_KEYBOARD " %s", state.label);
-
- lv_label_set_text(label, text);
}
+
+ lv_label_set_text(label, text);
}
static void layer_status_update_cb(struct layer_status_state state) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some various compiler warnings.