Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devcontainer): Add packages required by grpcio #2216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

c10l
Copy link

@c10l c10l commented Mar 22, 2024

When running pip3 install --user -r zephyr/scripts/requirements.txt (last step on https://zmk.dev/docs/development/setup), grpcio install fails with the following error:

FileNotFoundError: [Errno 2] No such file or directory: c++: c++

This happens due to missing dev tooling in the container.

When running `pip3 install --user -r zephyr/scripts/requirements.txt`
(last step on https://zmk.dev/docs/development/setup), grpcio install
fails with the following error:

    FileNotFoundError: [Errno 2] No such file or directory: c++: c++

This happens due to missing dev tooling in the container.
@c10l c10l requested a review from a team as a code owner March 22, 2024 00:16
@huber-th
Copy link
Contributor

Should this rather go into the dev-generic part of https://github.com/zmkfirmware/zmk-docker to include the dev tooling into the dev base image directly rather than just adding it to the devcontainer here?

@c10l
Copy link
Author

c10l commented Mar 23, 2024

I'm not sure but I opened one there and referenced this one.

@petejohanson
Copy link
Contributor

I'm... a little hesitant to do this; the reality is, this is coming in from requirements-extras.txt in Zephyr, which has a lot of stuff that is not required for normal users to just build for their keyboards.

We used to only document installing the requirements-base.txt deps from Zephyr, but it looks like that got changed in 82ff6d8 by Joel. @joelspadin is there a specific reason we changed that I don't recall, or could we go back to just recommending the base deps?

@petejohanson petejohanson self-assigned this Apr 11, 2024
@petejohanson petejohanson added the dependencies Pull requests that update a dependency file label Apr 11, 2024
@joelspadin
Copy link
Collaborator

I don't remember. I probably just copied it from the Zephyr docs somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants