CoinJoiClient.CreateRegisterAndConfirmCoinsAsync refactor

[csiki2]

Moving the RegisterInputAsync function from the method.
Contributes to #12790 (comment)

[molnard]

It is hard to review. It seems to me some variables got moved away to another class. By itself this is just an extra layer and adding more code plus deepening the references. Can you elaborate more on the concept what are you trying to achieve with this step?

[csiki2]

Currently we had an oversized "lambda" (RegisterInputAsync) in a big method (CreateRegisterAndConfirmCoinsAsync) with huge amount of disposable "local variables" that is very hard to read on the first place (for example what is used in the lambda and what's not).
The change itself is pretty straight forward: the used variables went to a disposable class and the RegisterInputAsync became a proper method with the extra input parameter.
Practically this is a prerequisite to add the feature since I will need to work on these (after the change) methods.

[molnard]

I got it. Basically you separated RegisterInputAsync method plus added an extra class for all the variables. It is a bit unusual to me but I saw the number of CancellationTokenSources that would have been needed to pass down to the method and it makes sense.

[lontivero]

NACK

If we agree with the problem as it is stated then the cleaner, easiest and more obvious solution is not to create a new type/abstraction but simply refactor the method:

The lambda (local function) can be moved/promoted as a class method. That method can receive the values that it needs instead of using the free variables.

[csiki2]

You make my work terribly difficult. Originally I wanted to add these whole class as an inside class, but David suggested to make it into a single file.
Now you state that having 8 using line is healthy and "only" the lambda should be moved.
I have already changes on top of this.
NVM, I create a completely new pull request without any cleanup.