[UI] Update avalonia 11.1.0-beta2

[wieslawsoltes]

TODO:

• Update avalonia 11.1.0-beta2
• There is issue with run in background on macOS, the tray icon is not visible when closed window in background - false alarm - it was just under other menu items as there was not enough space in tray :)
• Update Avalonia.Xaml.Behaviors package
• Blocked by regression in Avalonia Window can't be dragged using title bar and no caption buttons rendered with extend client area AvaloniaUI/Avalonia#15522

[soosr]

@wieslawsoltes

Where is the beta version stored? Which Nuget server?

[soosr]

@zkSNACKs/testing-team Please do a thorough test here. Here are the issues that are worth testing if get fixed: https://github.com/orgs/zkSNACKs/projects/18/views/57

[wieslawsoltes]

@wieslawsoltes

Where is the beta version stored? Which Nuget server?

On NuGet main servers https://www.nuget.org/packages/Avalonia/11.1.0-beta1

[wieslawsoltes]

Updated to latest Avalonia 11.1.0-beta2

[yahiheb]

Is it wise to update to beta versions?
Usually these Avalonia updates fix something and break other things under the hood.

@zkSNACKs/testing-team Please do a thorough test here. Here are the issues that are worth testing if get fixed: https://github.com/orgs/zkSNACKs/projects/18/views/57

I checked that board and it seems only #12678 is maybe worth fixing, the others are low priority.
Does this update fix a specific issue?

[wieslawsoltes]

Is it wise to update to beta versions? Usually these Avalonia updates fix something and break other things under the hood.

We are already shipping with nightly builds of Avalonia :) There is a lot of improvements and bug fixes between 11.0 and 11.1.

[yahiheb]

Is it wise to update to beta versions? Usually these Avalonia updates fix something and break other things under the hood.

We are already shipping with nightly builds of Avalonia :) There is a lot of improvements and bug fixes between 11.0 and 11.1.

True, but isn't this the source of bugs that keep coming back and we keep fixing them over and over?

[soosr]

@yahiheb

The UI team agreed to only update Avalonia if it is stable or at least it fixes some of our issues, instead of introducing a new one.
As of we are sure it fixes:

• PasswordEntryBox: incorrect/confusing entry point after incorrect password #12849
• And the issue with CI when it cannot restore the package.

And this is the point when the @zkSNACKs/testing-team comes into the picture... to run some tests on this PR.

[yahiheb]

@soosr

We can never be sure this doesn't introduce new bugs unless we test this extensively, and even if we do we always get new ones (at least from many past experiences).

Do you want the test-team to go through the whole application and test every bit of it just for #12849 which seems to be not so relevant issue?

PRs/features are best tested by those who write the code and know what parts of the software are affected by their changes.
The test-team's role is just secondary/complementary.

[soosr]

@yahiheb

We can never be sure this doesn't introduce new bugs unless we test this extensively, and even if we do we always get new ones (at least from many past experiences).
Do you want the test-team to go through the whole application and test every bit of it just for #12849 which seems to be not so relevant issue?

Here you can read the main changes https://github.com/AvaloniaUI/Avalonia/releases, we are currently on a version that is between 11.0.9 and 11.0.10.

• This releases intent to fix Inlines which holds back several issues: [UX/UI redesign] Coloring and Grouping Numbers #10838, Separate OR color differentiate amounts in 3 digit chunks #2588, [UX] Use play/pause/stop icons instead of words with the musicbox messages  #11567, Use thin space as digit grouping separator #10518.
• Introduces Font Features so we can remove the monospaced font and also takes a step toward fixing inconsistency in 0 or Ø being displayed #10609.
• The package is the main Nuget server so our CIs will fail less often due to not reaching Avalonia's Nuget server. Also, there won't be unexpected release blockers for @molnard.
• There were tons of bug fixes so some of our issues got fixed for sure and probably more that we don't yet know about.

Yeah obviously it can happen some other parts will be broken, that is why we are here... to test it, report the issues to Avalonia, get them fixed, make sure everything is fine, and only update when we are sure.

PRs/features are best tested by those who write the code and know what parts of the software are affected by their changes. The test-team's role is just secondary/complementary.

No.

The Developer and Testing team both have their responsibilities. The developer is responsible for the initial testing to make sure everything they changed works well. Once that is done then comes the testing team. Who's responsibility is double-checking that the new feature that the developer introduced works well and also to check that the changes work well with the existing system, meaning it did not break the existing parts.

Since this PR updates the Avalona version, which literally touches the whole UI, and also taking the fact that the developer is on Mac and the testing team contains one Windows user and one Linux user, it would make a lot of sense for these 3 people to click through the application, and test it since there is no other way of testing it.

[soosr]

@wieslawsoltes The titlebar is broken on windows, cannot drag the application, the close, minimize, full screen buttons are missing.

[wieslawsoltes]

@wieslawsoltes The titlebar is broken on windows, cannot drag the application, the close, minimize, full screen buttons are missing.

Looks like a bug in 11.1.0-beta2 could also repro

[wieslawsoltes]

Seems like title bar has wrong layout

[wieslawsoltes]

Seems like title bar has wrong layout

Probably related to this property setting on MainWindow:

ExtendClientAreaChromeHints="Default, PreferSystemChrome, OSXThickTitleBar"

[wieslawsoltes]

Seems like title bar has wrong layout

Probably related to this property setting on MainWindow:

ExtendClientAreaChromeHints="Default, PreferSystemChrome, OSXThickTitleBar"

[wieslawsoltes]

@wieslawsoltes The titlebar is broken on windows, cannot drag the application, the close, minimize, full screen buttons are missing.

@soosr Reported the issue AvaloniaUI/Avalonia#15522