SQLite: Disable connection pooling for block filter SQLite database #12896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
kiminuo
force-pushed
the
feature/2024-04-18-Disable-pooling
branch
from
7d0bd41
to
79bdb85
Compare
kiminuo
changed the title
kiminuo
force-pushed
the
feature/2024-04-18-Disable-pooling
branch
from
79bdb85
to
551bc73
Compare
turbolay
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that we don't really use SQLite connection pooling for anything.
The pooling feature is useful when one creates and tears down connections. We have just one connection though that lives as long as the application lives.