New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Send: Manual Control 2 #12888
base: master
Are you sure you want to change the base?
[UI] Send: Manual Control 2 #12888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The amount isn't centralized and its look should match the Figma design.
- Navigating back should be possible from Send.
- After restringing the coins in the manual control screen, on the Transaction Preview when opening the Review Coins dialog, only the restricted coins should be in the list.
- Selected 1 coin, clicked MAX, then the Privacy suggestions seem to be stuck. It was loading forever.
@ichthus1604 |
Fixed.
Fixed.
Fixed.
Done. |
Implemented this. I'm not sure it's working 100% correctly, because I don't have a wallet with many different labels to test with. Can you confirm? |
Works fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The position of Back, Cancel, and Continue buttons on the dialog is wrong.
- The Amount background is visible when there is no selection.
- When the Amount become visible, the position of Cancel and Continue button shifts.
- The default option should be also visible in the SubActions.
- See Figma for designs and icons.
- https://www.figma.com/file/NykhItqdw5zQ4t4K9yBnkn/2.0.8?type=design&node-id=0-1&mode=design&t=wqpqwpSzN51Yl4lP-0
Fixed. |
@ichthus1604 Is there any blocker for keeping the original positions (as on master) of the cancel, continue button on the dialogs? |
Fixed. I had fixed vertical margins, but I didn't realize horizontal margins were also wrong. |
WIP.
New PR to minimize changes made in previous one.
SubActionButton
is available.