Mix to another wallet

[Whem]

fixes: #12695

[MaxHillebrand]

on 842aeec

1. load the sending wallet
2. create a new wallet
3. the newly created wallet does not show up in the output wallet dropdown of the sending wallet coinjoin settings.

---

it seems there is address reuse, with multiple payments to the same pubkey?

[43] INFO	PaymentBatch.AddPayment (36)	Payment df92e811-4674-44de-8a62-4be254976427 for 0.00059049 BTC to 0 f5e9cd2486bc11b9e1e8442f9d74fdbdc7057c17.
[43] INFO	PaymentBatch.AddPayment (36)	Payment 66acf83b-83ad-44e5-91f7-38c99f2404f6 for 0.00531441 BTC to 0 f5e9cd2486bc11b9e1e8442f9d74fdbdc7057c17.
[43] INFO	PaymentBatch.AddPayment (36)	Payment 7cacb2b2-c065-46aa-bf11-f0c4aa60a7a6 for 0.00531441 BTC to 0 f5e9cd2486bc11b9e1e8442f9d74fdbdc7057c17.

[soosr]

first round of review

[Whem]

on 842aeec

1. load the sending wallet
2. create a new wallet
3. the newly created wallet does not show up in the output wallet dropdown of the sending wallet coinjoin settings.

Fixed

[MaxHillebrand]

I still see multiple times the same pubkey for different payment requests in the log.

Are you sure that it generates a unique address for each destination output?

[molnard]

cACK.

Since it is not required to save the output wallet - you could try to use walletId - it will simplify the code.

[molnard]

@lontivero can you take a look at this change? 743c0e0

We also need to set the consolidation mode, for the same reason as you did in the RPC. I made it "automatic". This is the solution with the less diff.

[turbolay]

I made a review in the other PR that got merged. Sending notification here as well #12997 (review)

Just nits, the actual logic and code seems great to me. PR is nice.

[soosr]

tACK