[PoC] Payment aware CoinjoinCoinSelector #12646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarnixCroes
reviewed
Mar 10, 2024
| @@ -80,6 +80,55 @@ public ImmutableList<TCoin> SelectCoinsForRound<TCoin>(IEnumerable<TCoin> coins, | |||
| .Where(x => x.IsRedCoin(SemiPrivateThreshold)) | |||
| .ToArray(); | |||
|
|
|||
| if (WalletPrivateButHasPendingPayments(pendingPaymentsAmount, semiPrivateCoins.Length, redCoins.Length)) | |||
| { | |||
| var maxRegistreableAmountPrivateCoins = privateCoins.OrderByDescending(x => x.Amount).Take(MaxInputsRegistrableByWallet).Sum(x => x.Amount); | |||
There was a problem hiding this comment.
some inconsistency in using Registreable or Registrable throughout the PR
Suggested change
| var maxRegistreableAmountPrivateCoins = privateCoins.OrderByDescending(x => x.Amount).Take(MaxInputsRegistrableByWallet).Sum(x => x.Amount); | |
| var maxRegistreableAmountPrivateCoins = privateCoins.OrderByDescending(x => x.Amount).Take(MaxInputsRegistrableByWallet).Sum(x => x.Amount); |
|
This PR is still relevant, and should be finished, I'm closing it simply because I will not maintain it in a foreseeable future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12638
There are 3 ideas here, that only change behavior if all coins are private and there are pending payments:
StopWhenAllMixed = false)MaxInputsRegistrableByWalletinputs, mix inConsolidationModeto try to create bigger outputs to be able to perform the payment in a later coinjoinIf not all our coins are private, nothing changes.
It's a POC because there are optimizations and better factoring possible.
@lontivero can you tell me what you think about the concept please?