crash when starting wallet: walletfilterprocessor: An attempt was made to transition a task to a final state when it had already completed

[MarnixCroes]

General Description

crashed at wallet login

How To Reproduce?

dotnet run

can't repro yet

Operating System

deb12

Logs

2024-04-24 18:48:16.774 [8] INFO	WalletManager.StartWalletAsync (220)	Starting wallet 'Testint'...
2024-04-24 18:48:18.342 [8] INFO	Wallet.LoadWalletStateAsync (470)	Initial Transaction Processing finished in 1.53 seconds.
2024-04-24 18:48:21.886 [16] WARNING	WalletFilterProcessor.ExecuteAsync (167)Tried to set exception for NonTurbo but status was already RanToCompletion.
2024-04-24 18:48:21.888 [16] ERROR	WalletFilterProcessor.ExecuteAsync (189)System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.
   at System.Threading.Tasks.TaskCompletionSource.SetResult()
   at WalletWasabi.Wallets.WalletFilterProcessor.ExecuteAsync(CancellationToken cancellationToken) in WalletWasabi/Wallets/WalletFilterProcessor.cs:line 132
2024-04-24 18:48:21.948 [6] INFO	WasabiAppBuilder.TerminateApplicationAsync (139)	Wasabi GUI stopped gracefully (5695ed86-9890-443c-a91c-d4551d1b36bf).
2024-04-24 18:48:21.951 [6] WARNING	Global.DisposeAsync (434)	Process is exiting.
2024-04-24 18:48:21.952 [6] INFO	Wallet.StartAsync (309)	Starting of wallet 'Testint' finished in 5.18 seconds.

[some shutdown logs]

2024-04-24 18:48:22.015 [24] INFO	Global.DisposeAsync (561)	AllTransactionStore is disposed.
2024-04-24 18:48:22.015 [1] INFO	TerminateService.Terminate (184)	Wasabi stopped gracefully (5695ed86-9890-443c-a91c-d4551d1b36bf).
2024-04-24 18:48:22.025 [1] INFO	WasabiAppBuilder.BeforeStopping (105)	Wasabi GUI stopped gracefully (5695ed86-9890-443c-a91c-d4551d1b36bf).
2024-04-24 18:48:22.035 [1] CRITICAL	Program.Main (80)	System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.
   at WalletWasabi.Fluent.Desktop.Program.Main(String[] args) in WalletWasabi.Fluent.Desktop/Program.cs:line 67

Wasabi Version

f8305d2

[molnard]

Happened to me as well - twice. win64 f8305d2

[molnard]

I was loading a TestNet wallet. The loading was done and I was on the wallet screen after a while there was a crash.

46368015a2734edf43ee51f4f11d38190950b7 acquired from node 'HandShaked ([::ffff:127.0.0.1]:18333)'.
2024-04-25 11:15:22.866 [12] INFO       Wallet.ExecuteAsync (361)       Wallet 'WalletTestNet' is fully synchronized.
2024-04-25 11:15:25.089 [11] INFO       MempoolService.TryPerformMempoolCleanupAsync (113)      78 transactions were removed from mempool.
2024-04-25 11:15:25.361 [27] WARNING    WalletFilterProcessor.ExecuteAsync (167)        Tried to set exception for NonTurbo but status was already RanToCompletion.
2024-04-25 11:15:25.362 [27] ERROR      WalletFilterProcessor.ExecuteAsync (189)        System.InvalidOperationException: An attempt was made to transition a task to a final state when it had already completed.
   at System.Threading.Tasks.TaskCompletionSource.SetResult()
   at WalletWasabi.Wallets.WalletFilterProcessor.ExecuteAsync(CancellationToken cancellationToken) in WalletWasabi\Wallets\WalletFilterProcessor.cs:line 132
2024-04-25 11:15:25.414 [13] INFO       WasabiAppBuilder.TerminateApplicationAsync (139)        Wasabi GUI stopped gracefully (de776150-43da-4ad6-b589-f78013387893).
2024-04-25 11:15:25.417 [13] WARNING    Global.DisposeAsync (434)       Process is exiting.

Before that, my client suffered many inconsistent filter state, so I restarted Wasabi many times.

2024-04-25 11:10:00.359 [12] INFO	TorMonitor.MonitorEventsAsync (150)	Tor circuit was established.
2024-04-25 11:10:03.931 [13] INFO	SatoshiSynchronizer.ExecuteAsync (151)	Inconsistent index state detected.
Local chain: 2670550/2670550 (0 left- best known block hash: 000000000000026904a352cae810c27e38b87ee97d173a467542874475367d3f
Received filter: 00000000000004e11ee35f0f72ebbd9d4708f10bf70c7e2ed5a8703afa5bff95 height: 2670552
2024-04-25 11:10:06.723 [14] INFO	WalletManager.StartWalletAsync (220)	Starting wallet 'DanielWallet'...

[molnard]

@turbolay can be related to non-turbo sync?

[kristapsk]

Another issue with large reorgs on testnet?

[molnard]

Another issue with large reorgs on testnet?

That can catalyze the issue, yes.

[turbolay]

Please mention here if someone can reproduce it after 06ede9d, I'm not closing as I'm not sure that #12939 was a full fix