Remove filters from BlockFilterIterator after a reorg #12939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
reviewed
Apr 27, 2024
kiminuo
reviewed
Apr 27, 2024
kiminuo
reviewed
Apr 27, 2024
| Cache.Remove(heightToRemove); | ||
| } | ||
| } | ||
|
|
||
| public void Clear() | ||
| { | ||
| Cache.Clear(); |
There was a problem hiding this comment.
This line is not under lock. It should, shouldn't it?
There was a problem hiding this comment.
I was thinking about it as well but it's under lock when it's used. We can rename it ClearNoLock if you want?
Then create a new function for the usage in WFP
While I know that using a traditional lock when already being in the critical state of the lock has no effect, I'm unsure about AsyncLock's behavior, hence I didn't add it here.
There was a problem hiding this comment.
Yes. Thanks. I just improved it by 418f810 as that's harder to break.
kiminuo
reviewed
Apr 27, 2024
kiminuo
reviewed
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should at least contribute to #12931