Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: support detached child processes #19226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

izaakschroeder
Copy link

@izaakschroeder izaakschroeder commented Mar 9, 2024

Does what it says on the box.

TODO:

  • Test manually on macOS
  • Test manually on Windows
  • Test manually on Linux
  • Test suite locally on macOS
  • Test suite locally on Windows
  • Test suite locally on Linux
  • Test failure cases and map any expected errors to something useful

Testing

Existing tests ran via:

mkdir -p build
cd build
cmake .. -DZIG_STATIC_LLVM=ON -DCMAKE_PREFIX_PATH="$(brew --prefix llvm);$(brew --prefix zstd)"
make install
stage3/bin/zig build -p stage4 -Denable-llvm -Dno-lib
stage4/bin/zig build test-std -Dskip-release

Verified manually on macOS 14.3.1 (23D60).

Refs: #19205

Does what it says on the box.

Refs: ziglang#19205
@izaakschroeder
Copy link
Author

@andrewrk this is my first PR 😄 not really sure on the process or if there's anything else you'd like me to do? I don't have ready access to a Windows machine so that might be a bit hard for me to test.

@Vexu
Copy link
Member

Vexu commented Mar 15, 2024

Since std.process.Child is a cross-platform API you could write a test for it that you confirm works on macOS and then let the CI test it on Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants