[WIP] The implements of some v2 concepts for discuss only #457

halx99 · 2021-12-23T12:21:07Z

CHANGES

Add length field and update length field at parse & setter time
All string getter/setter function use string_view_t
Add explicit boolean type for store bool value as string value true, false and avoid compiler ambiguous match const char_t* as scalar type 'bool'
Improve performance string literal value assignment with shallow copy support
Since getter function return string_view, if you needs get char_t* as 1.11.x, just invoke string_view::data(), it never return nullptr, this behavior same with v1.11.x

TODO:

Since setter is string_view, some tests can modify to use string_view literal svavoid strlen

sub pull-requests

This is the same fix as zeux#497, but we're using auto_deleter instead because if allocation function throws, we can't rely on an explicit call to deallocate. Comes along with two tests that validate the behavior.

halx99 added 27 commits September 29, 2021 10:37

Initial string_view for set_name, set_value

15697a7

Add explicit boolean type for store as 'true' or 'false'

3a975d2

Use string_view when needs store

aeda2ef

Use basic_string_view<char_t> instead of string_view

b79d580

Fix appveyor msvc120 compile error

5f1eb20

Fix compile issue for compiler without cpp11

4ed7a7f

Avoid unnecessary strlen operations

fd795fd

Fix for non-cpp11 compiler

e3af244

Fix for non-cpp11 compiler

bffbcfd

Update pugixml.hpp

dbced76

Fix for non-cpp11 compiler

4852708

Add shallow_copy support for improve performance of literal string

0d9a303

Make logic more clearly

366113e

Fix logic

15cec5f

Delete unused

bd0fd02

Add length field for name & value

909b3b6

Add string_view name & value getter with suffix for compatible

69e24c7

Update build.yml

233d7fd

Fix warnings on PUGIXML_WCHAR_MODE

4e4af11

Fix for old compilers

b025069

Fix ci

9129d79

Store length for setters

7791e7d

Node copy avoid stringlen operation

b634ea5

Use string_view for all dom APIs

32cccfe

Fix ci & add run test cost

0d87d4f

Fix warnings

46805e8

Fix ci

f0259eb

halx99 marked this pull request as draft December 23, 2021 12:21

This was referenced Dec 23, 2021

[WIP] Improve performance string literal value assignment with shallow copy support #442

Closed

[WIP] string_view support #441

Closed

halx99 and others added 17 commits December 23, 2021 21:14

Add missing commit from shallow_copy branch

d3a8b86

Update pugixml.cpp

3ceb703

Fix for compact mode

c95044d

Allow build compact mode

3c9111d

More string_view

d6fac0a

Fix ci

6c2bb13

Merge branch 'zeux:master' into dev

ce19f19

Fix memory leak

62e2407

Fix memory leak during OOM in convert_buffer

7f2d74d

This is the same fix as zeux#497, but we're using auto_deleter instead because if allocation function throws, we can't rely on an explicit call to deallocate. Comes along with two tests that validate the behavior.

Use more idiomatic code in this codebase

1c6a55f

C++20 compiler support

4bec1e8

c++ 20 compiler support

72e3201

c++20 compiler support

377a2a9

Fix ci

5d8dbac

Merge 'zeux-master' into dev

aee049f

Merge branch 'zeux-master' into dev

eae27e5

1.13 ABI compatible

f79549c

halx99 force-pushed the dev branch from 364ebb1 to f79549c Compare February 4, 2023 06:03

halx99 added 2 commits February 4, 2023 14:36

Fix ci

a328bb5

Fix ci

66e1430

stefanroellin mentioned this pull request Mar 4, 2023

Add overloads with size_t type argument #537

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] The implements of some v2 concepts for discuss only #457

[WIP] The implements of some v2 concepts for discuss only #457

halx99 commented Dec 23, 2021 •

edited

[WIP] The implements of some v2 concepts for discuss only #457

Are you sure you want to change the base?

[WIP] The implements of some v2 concepts for discuss only #457

Conversation

halx99 commented Dec 23, 2021 • edited

CHANGES

TODO:

sub pull-requests

halx99 commented Dec 23, 2021 •

edited