Skip to content
This repository has been archived by the owner on May 21, 2023. It is now read-only.

Use the Thread ID as the name for unknown thread #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CrossVR
Copy link
Contributor

@CrossVR CrossVR commented Jan 29, 2017

It isn't much, but this is slightly more useful than just using "Unknown".

@CrossVR CrossVR force-pushed the thread-id branch 3 times, most recently from d092aca to 3ad5522 Compare January 29, 2017 17:24
@zeux
Copy link
Owner

zeux commented Jan 30, 2017

I'm reluctant to merge this because I feel like a better solution is to keep both thread id & name and display both. That way you don't have to deduplicate thread names if you set them manually - you just have the thread id if you need it, always. The on-screen UI layer does this already but I think the web UI doesn't - there's potentially a simple fix for this that would just send the name in the web server in a similar format to what on-screen UI currently uses (see MicroProfileWriteThreadHeader in microprofileui.h), and wouldn't need further JS changes.

@CrossVR
Copy link
Contributor Author

CrossVR commented Jan 30, 2017

This change only affects threads that would previously be marked as "Unknown", it doesn't affect threads that have an actual name associated with them. I don't actually use the thread ID for anything, I just thought it was easier to read than three threads all called "Unknown".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants