Add Source::with_line_offset function #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zesterer
reviewed
Aug 14, 2021
| } | ||
| } | ||
| } | ||
|
|
||
| impl Source { | ||
| /// Add an offset to the line number displayed in the message. | ||
| pub fn with_line_offset<S: AsRef<str>>(source: S, line_offset: usize) -> Source { | ||
| Source { line_offset, ..Source::from(source) } |
There was a problem hiding this comment.
with_x might make more sense as a builder pattern (i.e: takes self, returns Self). This would be strictly more powerful.
Hamedpahlan
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's the PR discussed here: #6
I've cleaned it up a little to remove the auto-formatting and ensure that
Source::with_line_offsetusesAsRef<str>.