Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Expires added #989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Simounet
Copy link
Contributor

@Simounet Simounet commented Feb 4, 2016

Hi there,
It should be great to use these expire headers settings.

Have a nice day.

@Simounet Simounet changed the title Apache Expire added Apache Expires added Feb 4, 2016
@acrylian
Copy link
Member

acrylian commented Sep 2, 2016

Sorry for the lack of reply on this. We decided not to incorporate these (as you noticed…). First, the values set might not be the right for everyone and second, it might be better if people who know what they are doing (like you) set these if needed themselves. Maybe in the future we find a way to add something like this more dynamically.

@Simounet
Copy link
Contributor Author

Simounet commented Sep 2, 2016

I get your point but I think default values (maybe lower than mine) could be a great asset than no values at all. It's your call.

@youssefelmourabit
Copy link

+1

@thany
Copy link

thany commented Jul 4, 2017

These values are actually pretty pessimistic. I would personally set them to expire after much longer.
However, it is then up to the system to generate new urls for files that do change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants