Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of tinyZenpage #817

Open
vincent3569 opened this issue May 16, 2014 · 4 comments
Open

Improvement of tinyZenpage #817

vincent3569 opened this issue May 16, 2014 · 4 comments

Comments

@vincent3569
Copy link
Collaborator

hi

as far I can see, if we use tinyZenpage to add links to news, pages, albums or images, there is no rewrite of url.
for example:

  • a link to a page stays /index.php?p=pages&title=portfolio rather than /pages/portfolio
  • a link to a news stays /index.php?p=news&title=photo-du-mois-fevrier-2015 rather than http://test.vincentbourganel.fr/news/photo-du-mois-fevrier-2015
  • a link to an album stays /index.php?album=groupe-photo-ecully/portraits-bougie rather than /groupe-photo-ecully/portraits-bougie/
  • a link to an image stays /index.php?album=groupe-photo-ecully/portraits-bougie&image=img_6816.jpg rather than groupe-photo-ecully/portraits-bougie/img_6816.jpg.html.

this is not really consistent and all internal url should be rewrited.

@sbillard
Copy link
Contributor

Yes, TinyZenpage does not follow the object model. This results in the problem you note and others. For instance, it hard codes things like "news" and "category" so the rewrite tokens would be violated except for the fact that these parameters are never used.

Unfortunately, I think fixing this at this time is unwise as we are so close to release. These links do work, and the front end will redirect them to the rewritten version with a "301 Moved Permanently" status, so the impact is not so great.

Only people looking at the actual html will even know that these are query type links.

@acrylian
Copy link
Member

I agree we should not fix it now. tinyZenpage's code base is a lot older from when it was not possible to change the rewriteTokens and they were purely htaccess driven. The non rewritten urls were the ones that always would work regardless of mod_rewrite server support.

In any case tinyZenpage has to be updated to the TinyMCE 4 api anyway as it currently also uses the fallback for the version 3. I also would like to rework the interface a bit as well…

@sbillard
Copy link
Contributor

sbillard commented Jun 4, 2014

Not a complete solution, but check out the "Copy-able object links for all objects" implementation in
ZenPhoto20. Specifically, the crop image plugin will allow you to size and visually crop an image and then copy the image link. You then paste the link in the tinyMCE "insert image link".

@sbillard
Copy link
Contributor

sbillard commented Jun 6, 2014

The full implementation of this is now available in the ZenPhoto20 master branch.

@acrylian acrylian added this to the 2.0 milestone Jul 21, 2014
@acrylian acrylian changed the title 1.4.6.RC2: improvement of tinyZenpage Improvement of tinyZenpage Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants