Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.6 beta improvement of tinyZenpage and cacheManager #809

Closed
vincent3569 opened this issue May 2, 2014 · 7 comments
Closed

1.4.6 beta improvement of tinyZenpage and cacheManager #809

vincent3569 opened this issue May 2, 2014 · 7 comments
Milestone

Comments

@vincent3569
Copy link
Collaborator

hi
with i.php, we are allowed to create a cropped picture with these parameters:
i.php?a=[album_name]&i=[image_name]&w=[width of final picture]&h=[hight of final picture]&cw=[cropped width]&ch=[cropped hight]&cx=[width offset]&cy=[hight offset].

If I insert these value in a news, zenphoto create a cacheImage and replace the link with cacheImage URI:
/cache/[album_name]/[image_name]_w[width of final picture]_h[hight of final picture]_cw[cropped width]_ch[cropped hight]_cx[width offset]_cy[hight offset].jpg

but:

  • TinyZenPage doesn't allow to insert this cropped picture in a news or a page, I have to generate it manually, by editing html code before saving my news or page.
  • If I delete my cache, cacheManager doesn't want to refresh the cache with this picture.

It would be nice improvements if TinyZenPage and CacheManager could manage these cropped pictures.

one example here:
http://www.vincentbourganel.fr/news/nd-400-filter?locale=en_US
in html code, you could see these URI to a cropped pricture:
<img class="ombre" src="/cache/20110721-vacances-ete-pays-basque/img_5671_w800_h189_cw1100_ch260_cx0_cy40.jpg" alt="Cote Basque I">

I have to insert these code in my news to generate this cache link:
<img class="ombre" src="/zp-core/i.php?a=20110721-vacances-ete-pays-basque&i=img_5671.jpg&w=800&h=189&cw=1100&ch=260&cx=0&cy=40&wmk=!" alt="Cote Basque I">
and if I delete the cache, cacheManager (cache stored image tabs) doesn't recreate the cache image and I have this note:
Note: the following objects have images that appear to no longer exist. ND 400 filter (20110721-vacances-ete-pays-basque/img.jpg)

@acrylian
Copy link
Member

acrylian commented May 2, 2014

tinyZenpage has limited parameters for cropped images to be simple. We could possibly add more parameters. But I am not sure if that over complicates the usage with width/height/cropwidth/cropheight/cropx/cropy.

The cacheManager actually has options for all parameters. I admit I rarely use it myself so maybe I missed something?

@sbillard
Copy link
Contributor

sbillard commented May 2, 2014

If I delete my cache, cacheManager doesn't want to refresh the cache with this picture.

Cache manager should re-cache the image. I will look into this issue.

@vincent3569
Copy link
Collaborator Author

@acrylian:
sizing images by i.php parameters is a bit complicated and I understand that tinyZenpage is simple with it.
the nicer improvement would be to allow a visual cropping, as thumbail cropping and image cropping plugin...

@sbillard
cacheManager does not regenerate the image cache with the above URI and I get the notice.
I noticed that with the name of my cached image is:
<img class="ombre" src="/cache/20110721-vacances-ete-pays-basque/img_5671_w800_h189_cw1100_ch260_cx0_cy40.jpg" alt="Cote Basque I">
If the image is not cropped, the URI to the cached image is:
<img class="ombre" src= "/cache/groupe-photo-ecully/un-week-end-au-nd400/img_5221_350.jpg" alt="img_5221"> with not letters in size parametrers.

sbillard added a commit that referenced this issue May 2, 2014
@acrylian
Copy link
Member

acrylian commented May 2, 2014

@vincent3569: Yes, visual cropping would probably be nice indeed. I would like to rework the tinyZenpage interface anyway but it is one entry on a todo list for sometime after 1.4.6…

sbillard added a commit that referenced this issue May 3, 2014
sbillard added a commit that referenced this issue May 9, 2014
@vincent3569
Copy link
Collaborator Author

This commit solves the 2nd issue (cache images not generated): 9935dbb

I wish this ticket to stay open for the first demand about tinyZenpage.

@sbillard
Copy link
Contributor

The second issue is addressed by the new implementation in ZenPhoto20 that allows pick and paste of objects into tinyMCE. Use the crop image plugin to visually crop and size the image. But instead of saving it use the pick icon to pick the sized/cropped image for pasting into tinyZenpage with the tinyMCE:zen button/menu item.

@acrylian acrylian added this to the 2.0 milestone Jul 21, 2014
@acrylian
Copy link
Member

acrylian commented Aug 21, 2017

I will close this as it can be considere as part of #817 in general. We might not add visual cropping as TinyMCE itself allows cropping images and more as well. It does not cache them as we do but adds them as a data resource url then. https://www.tinymce.com/docs/demo/image-tools/ That plugin is generally enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants