New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pkg-config in Makefile.simple. #136
base: master
Are you sure you want to change the base?
Conversation
Hm, it's on Ubuntu only, it seems. Additionally, plain According to this, the |
And sure enough, plain |
On my OSX laptop, Just pushed an experiment. |
5d8d128
to
d03c4e4
Compare
Let's see if TravisCI is happy with this. Addresses, but does not fully resolve, zenorogue#135.
d03c4e4
to
d1a33b5
Compare
There, the capitalization is sorted out now. But I'm not keen to merge this half-measure. I'd be interested to hear from @akien-mga whether this is a step in the right direction. What else (if anything) needs to be done to support |
That is a step in the right direction, but what's missing is actually setting the compile flags, and not just linker flags. Note that |
FWIW, I wanted to say a bit about the original issue, #135. Compare the |
@still-flow Yes, and |
Sorry, I was probably stating the obvious (:. I don't disagree, I guess I just half-heartedly tried to say that this was an upstream issue. But upstream doesn't look like it's going to be updated anytime soon, so probably this needs fixing here. |
It's not an upstream issue. Upstream provides you the relevant information via That's why
BTW, I would advise to change |
My two cents: You're both (at least partly) right.
|
Thank you both for explaining. So from all of this, it seems like the best solution would be to ditch SDL1.2 altogether, got it (;. Well, the official migration guide is encouragingly not too long, so one of these days I might try going through it and seeing where it leads. (But I wouldn't suggest anyone hold their breath on that, so all of the above still applies.) |
Let's see if TravisCI is happy with this.
Addresses, but does not fully resolve, #135.
EDIT: Nope, GitHub CI's Linux build is not happy with
pkg-config sdl
. https://github.com/zenorogue/hyperrogue/runs/1276430655