New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New round of CI improvements/fixes #131
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod my comments. The only really really important one is the first one, about updating .travis.yml
with the new Docker image and/or s/docker/podman/
so that it stays in sync with the Github workflow.
55ce392
to
bff1e33
Compare
Addressed all Github-related stuff. Now it remains to update Travis and write some reports to GH support (about |
Of course, it has only now occurred to me to check this, but actually build artifacts also expire on a 90-day basis. Oops. Therefore, either the new helper workflow is entirely useless and has to be nuked, or a new storage solution has to be found. Either way, this'll need some more thought. |
Reports to Github support both done. Will post the responses if and when they occur. |
Updated Travis config (loosely) in sync with the Github one. Also excised the log-saver workflow for now. |
Workflow-cancelling action doesn't seem to function properly. I guess that's another ticket for GH support right there -- asking for an official way to do so. |
for Github CI: - exit->quit in gdb cmdlist - remove unnecessary backtrace gdb cmd - remove mymake output buffering for all platforms - remove `brew update` step - move from to-be-deprecated emscripten container also update Travis config in sync: - try and skip `brew update`
So, In better news, forcing no |
On log expiration: good news is that Github listened (not to imply that we were the only ones to complain). The fly in the ointment is that for free public repos 90 days is the upper retention limit :/. Can't blame them too much I guess: all that storage can add up quickly. Besides possible endemic workarounds, I wanted to try out Gitlab's reportedly-celebrated CI anyways. Will report if it's any good. |
The CI has been broken for a long time, which was annoying. I have removed the broken stuff:
Also fixed some warnings which caused some Linux/Windows checks to fail. |
Some small fixups:
brew update
step (to address Add -Wimplicit-fallthrough #69)OUTDATED (see below for details):