Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid Global styles / Garden styles clash #481

Merged
merged 1 commit into from
May 14, 2024

Conversation

Fredx87
Copy link
Contributor

@Fredx87 Fredx87 commented May 3, 2024

Description

This PR fixes the conflict between the global styles defined in the global CSS files with the styles defined by Garden.

There were some issues caused by the global styles applied to form elements that were also applied to Garden components.

  • All forms rendered in Curlybars now have the hbs-form class applied
  • All form element styles are scoped inside the hbs-form class or the search class for the form associated to the search helper
  • Removed ad-hoc fixes in the New Request Form components

Checklist

  • πŸ“— all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • β™Ώ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • πŸ“ changes are tested in Chrome, Firefox, Safari and Edge
  • πŸ“± changes are responsive and tested in mobile
  • πŸ‘ PR is approved by @zendesk/vikings

@Fredx87 Fredx87 marked this pull request as ready for review May 6, 2024 12:19
@Fredx87 Fredx87 requested a review from a team as a code owner May 6, 2024 12:19
@Fredx87 Fredx87 merged commit b6b3fcb into v4-alpha May 14, 2024
5 checks passed
@Fredx87 Fredx87 deleted the gianluca/style-clash branch May 14, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants