-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centered the search bar to make look more symmetric #426
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, small change then we’re good to merge.
@@ -233,6 +233,11 @@ a { | |||
|
|||
.input-search { | |||
height: 50px; | |||
padding-right: 50px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of padding here, let’s adjust it here so we’re consistent with the left side padding:
diff --git a/css/styles.css b/css/styles.css
index 9cac9e2..f6679a1 100644
--- a/css/styles.css
+++ b/css/styles.css
@@ -108,7 +108,7 @@ a {
#v {
font-size: 16px;
margin: 0 auto;
- padding-left: 50px;
+ padding: 0 50px;
text-align: center;
width: 100%;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This raises a broader task about overall cleaning up CSS selectors and not using IDs, but that’s a much bigger code change that’s just a “nice to have” one day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukundsutar hi, any chance you can revisit this?
Types of changes
What types of changes does your code introduce? Check all the boxes that apply:
Description
Final checklist:
Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!