Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual glitches in titlebar when there's an active prompt #9812

Merged
merged 1 commit into from Mar 26, 2024

Conversation

osiewicz
Copy link
Contributor

@osiewicz osiewicz commented Mar 26, 2024

It looks like a fractional traffic lights position doesn't play well with Mac 12+. Fixed #9775 and #9588. Related to #7339 and #8128

Release Notes:

  • Fixed visual artifacts on titlebar that appeared when there was a prompt active

It looks like a fractional traffic lights position doesn't play well with Mac 12+.
Related to #7339 and #8128
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 26, 2024
@osiewicz
Copy link
Contributor Author

osiewicz commented Mar 26, 2024

/cc @maxdeviant it looks like you were quite active in the original PR (#8128). I'd be curious to get your thoughts on this.

@maxdeviant
Copy link
Member

/cc @maxdeviant it looks like you were quite active in the original PR (#8128). I'd be curious to get your thoughts on this.

Just took a look and they look aligned to me with these changes:

image

I'm good with merging (wasn't really a fan of the fractional units to begin with) 👍🏻

@osiewicz osiewicz merged commit fc5a088 into main Mar 26, 2024
10 checks passed
@osiewicz osiewicz deleted the traffic-lights-alignment branch March 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal stripes on title bar when showing about dialog
2 participants