Horizontal stripes on title bar when showing about dialog

[warpdesign]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Click on Zed Preview -> About to show the about dialog.

Happens in both stable & preview releases.

Environment

Zed: v0.128.1 (Zed Preview)
OS: macOS 14.3.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

about_overlay_horizontal-stripes.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[osiewicz]

This happens for any prompt (e.g. for save prompts as well). I've found that it does not happen in fullscreen; with a bit of digging, it turned out that it is somehow related to us moving the traffic lights;
With this unsafe block gone, we no longer have these stripes show up with prompts:

zed/crates/gpui/src/platform/mac/window.rs

Lines 369 to 406 in fb6cff8

	unsafe {
	let close_button: id = msg_send![
	self.native_window,
	standardWindowButton: NSWindowButton::NSWindowCloseButton
	];
	let min_button: id = msg_send![
	self.native_window,
	standardWindowButton: NSWindowButton::NSWindowMiniaturizeButton
	];
	let zoom_button: id = msg_send![
	self.native_window,
	standardWindowButton: NSWindowButton::NSWindowZoomButton
	];
	let mut close_button_frame: CGRect = msg_send![close_button, frame];
	let mut min_button_frame: CGRect = msg_send![min_button, frame];
	let mut zoom_button_frame: CGRect = msg_send![zoom_button, frame];
	let mut origin = point(
	traffic_light_position.x,
	titlebar_height
	- traffic_light_position.y
	- px(close_button_frame.size.height as f32),
	);
	let button_spacing =
	px((min_button_frame.origin.x - close_button_frame.origin.x) as f32);
	close_button_frame.origin = CGPoint::new(origin.x.into(), origin.y.into());
	let _: () = msg_send![close_button, setFrame: close_button_frame];
	origin.x += button_spacing;
	min_button_frame.origin = CGPoint::new(origin.x.into(), origin.y.into());
	let _: () = msg_send![min_button, setFrame: min_button_frame];
	origin.x += button_spacing;
	zoom_button_frame.origin = CGPoint::new(origin.x.into(), origin.y.into());
	let _: () = msg_send![zoom_button, setFrame: zoom_button_frame];
	origin.x += button_spacing;
	}

[CurbaiCode]

I think this is a duplicate of #9588.