Resolve threads on discussions #893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go version to fix issues during tests where some tests requires a specific go version, above 1.17 we had setup for lab. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Make sure our CI follows the same go version stated in go.mod. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Fix styling issue reported by gofmt. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Unfortunately our testing infra relies on a real environment that get updated from time to time. This commit updates the MR number to match the test code with the actual MR live in the testing repo. Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
With commit 4d1dbfa ("cmd/mr_discussion.go: Switch from NotePosition to PositionOptions") the PositionOptions object was being created regardless the presence of --position in user's command, causing the REST API to fail due to the presence of a "position" parameter in the request without all required arguments. This commit creates the PositionOptions object within the --position handler, ensuring it's not passed "empty". Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Add ability to resolve threads on the lab discussion cli. Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
Verify if the thread is already resolved Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --resolve to lab discussion cli.
Also check if thread is already resolved before resolving.
Depends on: #890