feat: use keep alive agents for all fragment requests #282
Conversation
vigneshshanmugam
commented
Jan 28, 2019
•
vigneshshanmugam
commented
- part of 4.0.0 Release #274
- Merge chore: Drop node 6 support, add 10 & 11 to travis #283 and rerun this test.
vigneshshanmugam
force-pushed
the
agent-keep-alive
branch
from
19c69e8
to
fa433e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 99.55% 99.56% +<.01%
==========================================
Files 17 19 +2
Lines 670 684 +14
Branches 127 128 +1
==========================================
+ Hits 667 681 +14
Misses 3 3
Continue to review full report at Codecov.
|
vigneshshanmugam
force-pushed
the
agent-keep-alive
branch
from
412171a
to
fa433e7
Compare
|
|
||
| class AgentStore { | ||
| constructor() { | ||
| const defaultAgentOpts = { socketActiveTTL: SOCKET_TTL }; |
There was a problem hiding this comment.
The socket ttl should be configurable
There was a problem hiding this comment.
Hmmm, I was thinking the same as well, Plus have to come up with custom config options for circuit breaker pool settings + metrics + caching of fragments..
I will come up with some proposal.
There was a problem hiding this comment.
Thought for a while about this and I think we can customize all of the logic in a client library like perron(or create one specific for tailor - or give PR to perron to make it work). Perron already supports circuit breaker logic for clients and we can easy add cache specific logic as well..
I will give PR to perron once i have sometime to work on some features.
