Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#426 module-info.java is placed in the wrong jar #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#426 module-info.java is placed in the wrong jar #483

wants to merge 1 commit into from
+2 −2

Conversation

viktor44
Copy link

@viktor44 viktor44 commented Aug 4, 2023

Description

Fixes #426

File module-info.class was moved from META-INF/versions/9 to the root folder of the jar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@m4ttek m4ttek mentioned this pull request Aug 16, 2023
Open
@MALPI
Copy link
Member

MALPI commented Sep 2, 2023

I will take a look in the next days.

@MALPI MALPI self-assigned this Sep 2, 2023
@viktor44
Copy link
Author

Up! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whiskeysierra whiskeysierra Awaiting requested review from whiskeysierra whiskeysierra is a code owner

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando lukasniemeier-zalando is a code owner

Assignees

@MALPI MALPI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module-info.java is placed in the wrong jar
2 participants
@viktor44 @MALPI