instance termination plugin support #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcillo
reviewed
Dec 23, 2019
| @RequestMapping(method = GET) | ||
| public ResponseEntity<String> healthCheck() { | ||
| if (terminationService.isTerminating()) { | ||
| return ResponseEntity.status(HttpStatus.IM_A_TEAPOT_418).build(); |
There was a problem hiding this comment.
Is this meant to be used by Nakadi Proxy? When maintaining the list of healthy Nakadi instances, those who report 418 during health check will not be added to the final result but at the same time not marked as unhealthy?
| @@ -493,11 +505,15 @@ public Builder setKpiCollectionFrequencyMs(final long kpiCollectionFrequencyMs) | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder setTerminationService(final TerminationService terminationService) { | |||
There was a problem hiding this comment.
I see that this is set also in the constructor. Is this used or needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
it should be possible to notify nakadi about coming instance termination, that it can release used resources and prepare itself for termination. A good example would be subscription connection termination in clean way, that consumer will not wait commit timeout
PR is not compilable due to plugin api change, which is expected here zalando-nakadi/nakadi-plugin-api#10