Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set the default behavior of openNote #3936

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

tevenfeng
Copy link

Add an option in settings to let the users choose whether to open a new note in a new tab or in the current tab.

@tevenfeng tevenfeng changed the title Add option to set the default action of openNote Add option to set the default behavior of openNote May 13, 2023
@zadam
Copy link
Owner

zadam commented May 13, 2023

Hi, can you please give some rationale for this config option?

It looks like you want to be able to open notes from the tree in new tab by default?

@tevenfeng
Copy link
Author

Hi, can you please give some rationale for this config option?

It looks like you want to be able to open notes from the tree in new tab by default?

Yes, sometimes i will open multiple notes at the same time. And opening new note in current tab would be kinda annoying in this occasion, so i add this option

@zadam
Copy link
Owner

zadam commented May 13, 2023

But can't you just right click - open in new tab? Or just hold CTRL when clicking, it will open in a new tab ...

@tevenfeng
Copy link
Author

tevenfeng commented May 14, 2023

But can't you just right click - open in new tab? Or just hold CTRL when clicking, it will open in a new tab ...

Cause it will just open the note in a new tab but it does not foucs on the new opened tab. Maybe we could just fix this.

Well actually I'm not quite used to those ways, and opening a note in a new tab as the default behavior is just my piece of cake. It would be fine if we don't merge this pr, just a patch for myself LOL

@meichthys
Copy link
Collaborator

meichthys commented May 24, 2023

it will just open the note in a new tab but it does not foucs on the new opened tab

Yes, I've found this a little counter-intuative. The newly opened tab should be focused/active after it is added to the split in the editor.

I've created #3970 to track this potential change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants