Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add logging package #55

Closed
felixhoffmnn opened this issue Oct 20, 2022 · 1 comment · Fixed by #65
Closed

[Feature] Add logging package #55

felixhoffmnn opened this issue Oct 20, 2022 · 1 comment · Fixed by #65
Assignees
Labels
feature New feature or request

Comments

@felixhoffmnn
Copy link

felixhoffmnn commented Oct 20, 2022

Summarize the feature
To easier determine errors, it would be handy if a logging package would be used. For that, I recommend Loguru.

Example of the feature
Loguru enables the developer to just import from loguru import logger and then use logging levels like debug, info, and error. In comparison to the default logger, Loguru logs are already nicely formatted.

Additional context
As an alternative, the built-in logging package could be used.

@felixhoffmnn felixhoffmnn added the feature New feature or request label Oct 20, 2022
@zaanposni
Copy link
Owner

Even though I like loguru - it looks really cool - I think we should rather use the pythons default logging module.
One can also edit the log format and logging level but we do not need to add another third party requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants